Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to icepack bgc documentation #499

Closed
wants to merge 1 commit into from
Closed

Updates to icepack bgc documentation #499

wants to merge 1 commit into from

Conversation

njeffery
Copy link
Contributor

@njeffery njeffery commented Sep 9, 2024 •
edited
Loading

Updates the zbgc and zaerosol documentation.

BFB

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • [X ] Short (1 sentence) summary of your PR:
    ENTER INFORMATION HERE
  • Developer(s):
    @njeffery ; @eclare108213 ; @apcraig
  • [X ] Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    made the documentation using Sphinx
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • [ X] No
  • Does this PR add any new test cases?
    • Yes
    • [ X] No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • [X ] Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

-Added descriptions for DIC, carbon conservation, and implicit grazing. -Added description for the saturation concentration. -Changed language in config file to English.
-Added two references.

@njeffery
Updates to icepack bgc documentation
7abc335 
-Added descriptions for DIC, carbon conservation, and implicit grazing.
-Added description for the saturation concentration.
-Changed language in config file to English.
-Added two references.

BFB
@njeffery
Copy link
Contributor Author

njeffery commented Sep 9, 2024

@eclare108213 and @apcraig : I've updated the documentation for icepack bgc. Not sure if this PR is to the right branch. I couldn't add reviewers in the side column. Not sure why.

@apcraig
Copy link
Contributor

apcraig commented Sep 10, 2024

This should be PRed to my Icepack branch,

https://github.com/apcraig/Icepack/tree/bgcpr1

I have PR'ed and merged this to my bgcpr1 branch and will close this. The updated documentation should be reviewed here,

https://cice-consortium-icepack--497.org.readthedocs.build/en/497/

@apcraig apcraig closed this Sep 10, 2024
@apcraig
Copy link
Contributor

apcraig commented Sep 10, 2024

See apcraig#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njeffery @apcraig